Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for raw_eos_cli #957

Merged
merged 3 commits into from
May 28, 2021

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented May 17, 2021

Change Summary

Add support for raw_eos_cli in eos_designs and eos_cli in eos_cli_config_gen

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Component(s) name

arista.avd.eos_designs
arista.avd.eos_cli_config_gen

Proposed changes

eos_cli_config_gen

Data model updated with:

# EOS CLI rendered directly on the root level of the final EOS configuration
eos_cli: |
  < multiline eos cli >

ethernet_interfaces:
  < interface >:
    # EOS CLI rendered directly on the ethernet interface in the final EOS configuration
    eos_cli: |
      < multiline eos cli >

port_channel_interfaces:
  < interface >:
# EOS CLI rendered directly on the port-channel interface in the final EOS configuration
    eos_cli: |
      < multiline eos cli >

vlan_interfaces:
  < interface >:
# EOS CLI rendered directly on the vlan interface in the final EOS configuration
    eos_cli: |
      < multiline eos cli >

router_bgp:
  vrfs:
    < vrf >:
      # EOS CLI rendered directly on the Router BGP, VRF definition in the final EOS configuration
      eos_cli: |
        < multiline eos cli >

eos_designs

Connected Endpoints data model updated with:

< connected_endpoints_keys.key >:
  < endpoint_1 >:
    adapters:
      - <...>
        # EOS CLI rendered directly on the ethernet interface in the final EOS configuration
        raw_eos_cli: |
          < multiline eos cli >
        port_channel:
          # EOS CLI rendered directly on the port-channel interface in the final EOS configuration
          raw_eos_cli: |
            < multiline eos cli >

Fabric-Topology data models updated with:

< spine | l3leaf | l2leaf | overlay_controller | super_spine >:
  defaults:
    # EOS CLI rendered directly on the root level of the final EOS configuration
    raw_eos_cli: |
      < multiline eos cli >
  nodes:
    <node>:
      # EOS CLI rendered directly on the root level of the final EOS configuration
      raw_eos_cli: |
        < multiline eos cli >

Network Services data models updated with:

tenants:
  <tenant>:
    vrfs:
      <vrf>:
        # EOS CLI rendered directly on the root level of the final EOS configuration
        raw_eos_cli: |
          < multiline eos cli >

        svis:
          <svi>:
            # EOS CLI rendered directly on the VLAN interface in the final EOS configuration
            raw_eos_cli: |
              < multiline eos cli >

            nodes:
              <node>:
                # EOS CLI rendered directly on the VLAN interface in the final EOS configuration
                # Overrides the setting on SVI level.
                raw_eos_cli: |
                  < multiline eos cli >

        l3_interface:
          - <...>
             # EOS CLI rendered directly on the Ethernet interface in the final EOS configuration
            raw_eos_cli: |
              < multiline eos cli >

        bgp:
          # EOS CLI rendered directly on the Router BGP, VRF definition in the final EOS configuration
          raw_eos_cli: |
            < multiline eos cli >

How to test

Added tests to molecule for all supported areas.

Checklist:

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels May 17, 2021
@github-actions github-actions bot requested review from carlbuchmann and titom73 May 17, 2021 11:27
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit 8463a24 into aristanetworks:devel May 28, 2021
@carlbuchmann carlbuchmann added this to the v2.2.0 milestone Jun 1, 2021
@titom73 titom73 mentioned this pull request Jun 11, 2021
@ClausHolbechArista ClausHolbechArista deleted the raw-eos-cli branch July 9, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants