Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting router pim sparse-mode ssm range #982

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

quulah
Copy link
Contributor

@quulah quulah commented May 28, 2021

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Related to #979

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

  • Add supports for specifying ssm range parameter on router pim

How to test

Checklist:

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

Copy link
Contributor

@onurgashi onurgashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! To be honest looks simple not sure if we should have the molecule. I'll let @carlbuchmann decide on this.

@github-actions github-actions bot requested a review from onurgashi May 31, 2021 11:00
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label May 31, 2021
@github-actions github-actions bot requested a review from carlbuchmann May 31, 2021 11:00
@quulah
Copy link
Contributor Author

quulah commented May 31, 2021

I was going through all of my PRs and added the ssm_range to the test.

Rebased to current devel as well.

@carlbuchmann
Copy link
Member

LGTM! To be honest looks simple not sure if we should have the molecule. I'll let @carlbuchmann decide on this.

@onurgashi - Yes, all PRs targeting eos_cli_config_gen requires a test - this allows us to refactor as required in time and insures the same outcome is preserved, it also eases the review process!

@titom73 titom73 added this to the v2.2.0 milestone Jun 2, 2021
@titom73 titom73 added the type: enhancement New feature or request label Jun 2, 2021
@titom73 titom73 linked an issue Jun 2, 2021 that may be closed by this pull request
3 tasks
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Template: OK
  • Documentation: OK
  • Molecule: OK
  • CI result: OK

@titom73 titom73 merged commit e7118dc into aristanetworks:devel Jun 4, 2021
@titom73 titom73 mentioned this pull request Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional parameter support for eos_cli_config_gen
4 participants