Add support for configuring interface_profiles and setting them on et…

[quulah]

Change Summary

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Documentation content changes
• Other (please describe):

Related Issue(s)

Related to #979

Requires merge of PR #1008 first.

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

• Add supports for specifying interface profile parameters as well as setting them on Ethernet interfaces

How to test

Checklist:

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have updated molecule CI testing accordingly
• All new and existing tests passed (pre-commit, make linting and make sanity-lint).

[quulah]

Rebased to current devel and added the Molecule test for the new interface_profiles variable.

Didn't expect the rest of the configs to change, but there was actually a profile: ALL in some of the older tests. Uploaded the changed file, but unsure how to continue with those.

[titom73]

Hello @quulah

profile: ALL was a key not rendered by eos_cli_config_gen. As each host in this test is considered as independent, you can just focus on your own test file (interface-profiles) for the configuration rendering.

I will go ahead and remove other references in qos and ethernet-interfaces hosts.

Besides that, all the PR is nice !

[titom73]

Hello @quulah

profile: ALL was a key not rendered by eos_cli_config_gen. As each host in this test is considered as independent, you can just focus on your own test file (interface-profiles) for the configuration rendering.

I will go ahead and remove other references in qos and ethernet-interfaces hosts.

Besides that, all the PR is nice !

Actually, I tried to push, but seems you have not enabled push from maintainers.

So, you can simply remove all references to profile: ALL in files listed above and update molecule.

[quulah]

👍 Did that, should be sorted out now.

[titom73]

All templates and CI definition look good. But interface-profile is missing from master templates for configuration and documentation.

Please add entry to cover your feature in global rendering. Indeed, output of CI is not rendering your unit test.

[quulah]

Good catch! Fixed now.

[titom73]

LGTM!

Thanks

[titom73]

As per Molecule, it seems there is a conflict with a key ingested by eos_designs that set profile inherited for port-profile out of EOS configuration.

Will take it on hold, time to review and see how to fix that with @carlbuchmann and @ClausHolbechArista

[ClausHolbechArista]

@titom73 Not sure why, but for some reason we have always set the profile: <avd port-profile> in the generated structured config. It is not used, so I suggest that we remove it from ethernet-interfaces.j2 and port-channel-interfaces.j2 under templates/connected-endpoints. I can do it in a seperate PR?

[ClausHolbechArista]

For AVD3.0 we could consider renaming the AVD "profiles" to "templates" to avoid the naming conflict.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[ClausHolbechArista]

PR #1008 has merged which removed the unintentional profiles. Please rerun molecule and commit updated artifacts.

[quulah]

Rebased and pushed as per @ClausHolbechArista request.

Something funky going on in the pipelines though:

x509: certificate is valid for legacy.python.org, not svn.python.org	https://svn.python.org/projects/external/Jinja-2.1.1/docs/_build/html/extensions.html

[ClausHolbechArista]

Yeah we tried to fix it with #1023
Can you try to pull that in

[ClausHolbechArista]

nevermind. I found another link. Time for weekend! :)

[ClausHolbechArista]

LGTM