Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for configuring router igmp ssm aware #984

Merged
merged 5 commits into from
Jun 11, 2021
Merged

Add support for configuring router igmp ssm aware #984

merged 5 commits into from
Jun 11, 2021

Conversation

quulah
Copy link
Contributor

@quulah quulah commented May 28, 2021 •
edited
Loading

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Related to #979

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

  • Add supports for specifying router igmp with ssm aware

How to test

Checklist:

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels May 28, 2021
@quulah quulah mentioned this pull request May 28, 2021
Closed
3 tasks
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label May 31, 2021
@quulah
Copy link
Contributor Author

quulah commented May 31, 2021

Rebased to current devel and added Molecule test.

@titom73 titom73 added the type: enhancement New feature or request label Jun 2, 2021
@github-actions
Copy link

github-actions bot commented Jun 3, 2021

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Jun 3, 2021
@titom73 titom73 added this to the v2.2.0 milestone Jun 3, 2021
titom73
titom73 approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@titom73 titom73 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will be merged after conflict will be fixed

  • Template: OK
  • Documentation: OK
  • Molecule: OK
  • CI result: OK

@github-actions
Copy link

github-actions bot commented Jun 7, 2021

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Jun 7, 2021
@github-actions github-actions bot requested a review from titom73 June 7, 2021 07:00
ClausHolbechArista
ClausHolbechArista requested changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing automated documentation in eos_cli_config_gen. I have submitted a PR towards your branch to fix this. Please merge that one in first and then we can merge this one.

@ClausHolbechArista ClausHolbechArista modified the milestones: v2.2.0, v3.0.0 Jun 11, 2021
@quulah
Merge pull request #1 from ClausHolbechArista/add-router-igmp-add-doc…
95278a9 
…umentation

Add documentation for router_igmp
@quulah
Copy link
Contributor Author

quulah commented Jun 11, 2021

Done!

ClausHolbechArista
ClausHolbechArista approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit cabcd5f into aristanetworks:devel Jun 11, 2021
@ClausHolbechArista ClausHolbechArista modified the milestones: v3.0.0, v2.2.0 Jun 11, 2021
@ClausHolbechArista ClausHolbechArista mentioned this pull request Jun 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@onurgashi onurgashi Awaiting requested review from onurgashi

@aphillipps aphillipps Awaiting requested review from aphillipps

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

@titom73 titom73 Awaiting requested review from titom73

Assignees

@quulah quulah

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: enhancement New feature or request
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@quulah @titom73 @ClausHolbechArista