-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Create pre-commit-hook #35
Merged
gmuloc
merged 4 commits into
aristanetworks:devel
from
Shivani-chourasiya:Pre-commit-hook
Jun 8, 2022
Merged
Chore: Create pre-commit-hook #35
gmuloc
merged 4 commits into
aristanetworks:devel
from
Shivani-chourasiya:Pre-commit-hook
Jun 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shivani-chourasiya
force-pushed
the
Pre-commit-hook
branch
from
June 2, 2022 07:34
6e3bcf0
to
3b1f0f0
Compare
Shivani-chourasiya
force-pushed
the
Pre-commit-hook
branch
from
June 2, 2022 10:28
3b1f0f0
to
9557948
Compare
gmuloc
requested changes
Jun 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it on my local AVD repo by adding
- repo: https://github.com/aristanetworks/j2lint.git
rev: pull/35/head
hooks:
- id: j2lint
in my .pre-commit-config.yaml
and it worked like a charm!
Thanks
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Shivani-chourasiya
force-pushed
the
Pre-commit-hook
branch
from
June 3, 2022 06:35
5951cc2
to
a9a6262
Compare
gmuloc
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #28
Changes proposed
Added .pre-commit-hooks.yaml file with the required keys to configure pre-commit-hook.
How to test?
Add the j2lint pre-commit hook inside your repository in .pre-commit-config.yaml.
Example-
Run command:
pre-commit run --all-files
Reference
https://pre-commit.com/