Skip to content

Commit

Permalink
Remove CORS middleware
Browse files Browse the repository at this point in the history
The AuthService used a CORS middleware as a remnant of the original
fork:
ajmyyra/ambassador-auth-oidc@43dd5ae

The CORS middleware permits requests with certain default methods and
headers. However, since the default answer is 200, what it actually does
is proxy the CORS requests for those methods. I don't like the fact that we
don't set the response code explicitly. We should either remove this middleware
or document its use clearly.

Cherry-pick from: arrikto#58
  • Loading branch information
jfrabaute authored and ajhfok committed Jul 7, 2023
1 parent 2ca6013 commit 7e74b8c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import (
"github.com/arrikto/oidc-authservice/authorizer"
"github.com/arrikto/oidc-authservice/oidc"
"github.com/arrikto/oidc-authservice/svc"
"github.com/gorilla/handlers"
"github.com/gorilla/mux"
"github.com/patrickmn/go-cache"
log "github.com/sirupsen/logrus"
Expand Down Expand Up @@ -78,7 +77,7 @@ func main() {
log.Infof("Starting server at %v:%v", c.Hostname, c.Port)
stopCh := make(chan struct{})
go func(stopCh chan struct{}) {
log.Fatal(http.ListenAndServe(fmt.Sprintf("%s:%d", c.Hostname, c.Port), handlers.CORS()(router)))
log.Fatal(http.ListenAndServe(fmt.Sprintf("%s:%d", c.Hostname, c.Port), router))
close(stopCh)
}(stopCh)

Expand Down
3 changes: 1 addition & 2 deletions web_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"strings"

"github.com/arrikto/oidc-authservice/logger"
"github.com/gorilla/handlers"
"github.com/gorilla/mux"
)

Expand Down Expand Up @@ -85,7 +84,7 @@ func (s *WebServer) Start(addr string) error {
),
)

return http.ListenAndServe(addr, handlers.CORS()(router))
return http.ListenAndServe(addr, router)
}

// siteHandler returns an http.HandlerFunc that serves a given template
Expand Down

0 comments on commit 7e74b8c

Please sign in to comment.