Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CORS middleware #10

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Commits on Aug 30, 2021

  1. Remove CORS middleware

    The AuthService used a CORS middleware as a remnant of the original
    fork:
    ajmyyra/ambassador-auth-oidc@43dd5ae
    
    The CORS middleware permits requests with certain default methods and
    headers. However, since the default answer is 200, what it actually does
    is proxy the CORS requests for those methods. I don't like the fact that we
    don't set the response code explicitly. We should either remove this middleware
    or document its use clearly.
    
    Cherry-pick from: arrikto#58
    jfrabaute committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    2793c45 View commit details
    Browse the repository at this point in the history