Download support vs. master commit around 2013-07 #11557
Conversation
|
FYI, from my quick look, it looks quite good. @vitallium Since this includes portions of your code, what do you think? Is it ready to be merged. @matthewlmcclure Some sanity tests are needed, see the existing tests. Also, since this involves adding a new API, post it to the mailing-list (RFC) unless it's already discussed and I missed it. |
|
I'd be happy to work on some tests if you and @vitallium agree that you'd like to merge an implementation of the current design. In #10052 (comment), @vitallium mentioned that he wanted to work on a different design that presented something like a download manager interface. There's a "File downloading" mailing list conversation about the current design. |
|
At the risk of scope creep, I changed the filename suggestion so that it uses the response Content-Disposition's filename rather than the request URL. |
|
@ariya is this close to approval? |
|
I think it looks good. What do you think @vitallium? |
| QMAKE_CFLAGS_RELEASE_WITH_DEBUGINFO += -O2 -MT -Zi | ||
| QMAKE_CFLAGS_DEBUG = -Zi -MTd | ||
| QMAKE_CFLAGS_RELEASE_WITH_DEBUGINFO += -O2 -MT -Zi -Fd$(DESTDIR)$(QMAKE_TARGET).pdb | ||
| QMAKE_CFLAGS_DEBUG = -Zi -MTd -Fd$(DESTDIR)$(QMAKE_TARGET).pdb |
There was a problem hiding this comment.
This change should not be in this pull request.
|
I think we need a couple of tests for this feature |
|
Bump. Looking forward to seeing this in the next version. |
|
Very much looking forward to this. |
|
Was sad to find that this feature is not yet supported. |
Unsupported content calls the onFilePicker callback, if a filename is returned, the download begins. onDownloadFinished is called when the download completes. ariya#10052
|
so did this ever get merged into a release? |
|
This is will be implemented as separate PR. |
|
@vitallium do you have any work in progress that I can take a look at? I would be happy to help with implementation and testing! |
This PR includes @vitallium's original changes for #10052 rebased on a master commit from 2013-07.