This repository has been archived by the owner on May 30, 2023. It is now read-only.
Adds require.resolve() functionality for better combatibility with node modules. #11972
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to know the filename that will be resolved by require comes in handy in many cases.
One example would be to use the resolved filename with
page.injectJs()
for injection of modules installed vianpm
.As things stand now, i use the
module._getFilename()
method to achieve the same.Adding it to
resolve
would make it easier to have code that runs both on node and phantomjs.See http://nodejs.org/api/modules.html#modules_all_together for examples in nodejs.