2.0

[vitallium]

Long live PhantomJS 2.0!

What's inside:

• moved to Qt 5 (5.3.0)
• fresh version of Webkit (not the latest)
• API are the same as in 1.9

[JamesMGreene]

🤘 You deserve much kudos, ;@vitallium, @KDAB, et al! Wish I could've helped more.

[ariya]

Well done @vitallium and friends! I'll take a look at this shortly.

Quick question to all: should we just drop this into master? Of course, before that I can create 1.x branch to continue the current master (before it is being replaced by this one). What do you guys think @detro @JamesMGreene?

[vitallium]

I'd place it to a separate branch, to fix all things. For example, WebServer module works unstable.

[alexshk]

👍 Thanks a lot. This solved issue with OSX 10.10 Yosemite

[sveisvei]

Kudos! What version of webkit will most likely ship with 2.0?

[vitallium]

@sveisvei http://trac.webkit.org/browser/trunk?rev=153112

[thoop]

Amazing work! 🍻

[JamesMGreene]

@vitallium: Are there any built binaries of this commit available?

[vitallium]

@JamesMGreene I have binaries for all platforms. Should I share them?

[JamesMGreene]

If possible, absolutely, yes. We'll get a lot more testers that way. 👍

[djleeds]

Yes, please do share the binaries. Thanks!

[thoop]

Any updates on sharing those binaries? Would love to start testing!

[ricoli]

may I ask which version of ghost driver does it have? :)

[ariya]

There seems to be permission/mode issues with some files, when building on OS X.

[ariya]

@vitallium I had to skip -icu to build qtbase on OS X. Is it mandatory to install ICU header files to build?

[vitallium]

@ariya yes. ICU is required to build QtWebkit.

[jiweigang1]

@vitallium where can i download the binaries ? thank you

[GehDoc]

@vitallium i managed to build it on Fedora 20 from your repository branch 2.0, but...

There was missing files, and file rights, in QT part, and broken google_breakpad / QT includes on pure phantomjs part.
I may have done something wrong (wrong repository ?). If not, I can send you the list of my changes (not a diff, unless you provide my a way to cleanup my build directory).

[vitallium]

@GehDoc Awesome! Yes, send the the list please! Thanks!

[GehDoc]

@vitallium here is the list : https://gist.github.com/GehDoc/99d4521fb3f3efd42995#file-build-phantomjs2-0-fedora20-20140706

I hope this will help

[vitallium]

@GehDoc Thanks! Stupid .gitignore file. I'll add missing files.

[KabanaSoft]

@vitallium - Could you please share the PhantomJS2 binaries? I would like to give them a test, thanks!

[yogu13]

@vitallium will you be sharing the binaries ? I wouldnt mind testing them.

[vitallium]

@ariya ping

[ariya]

@vitallium Linux build fails on breakpad. I see that breakpad is also updated in this PR. Any more info regarding this?

[vitallium]

@ariya new version of breakpad contains many fixes. So, I thought this will be a good idea to update it too. But, for now, I think I'll revert it. Should I revert it?

[ariya]

@vitallium Reverting will be useful. Then I can continue my Linux testing.

[vitallium]

Ok. I'll revert.

Sent from my iPhone

On 25 Jul 2014, at 22:20, Ariya Hidayat notifications@github.com wrote:

@vitallium Reverting will be useful. Then I can continue my Linux testing.

—
Reply to this email directly or view it on GitHub.

[vitallium]

Done! @ariya

[ariya]

Landed. Thank you!