Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Add linux build automation #13721

Closed
wants to merge 2 commits into from
Closed

Conversation

mtparet
Copy link

@mtparet mtparet commented Nov 9, 2015

Description

  • Add Dockerfile / circleci to build phantomjs
    This will permit to get a linux binary and verify the compilation is working.

We can download the binary for each build https://circleci.com/gh/ifeelgoods/phantomjs/3#artifacts.

@vitallium
Copy link
Collaborator

I wonder if CircleCI can handle our build. I see they offer Build Minutes per Month 1,500. I don't think this is enough for PhantomJS.

@mtparet
Copy link
Author

mtparet commented Dec 2, 2015

Indeed this would lead to only 16 builds possible by month...

@vitallium
Copy link
Collaborator

Can they be triggered manually? And can we do builds for all supported platforms?

@mtparet
Copy link
Author

mtparet commented Dec 2, 2015

To build for windows, we need dedicated CI like http://www.appveyor.com/ for OS X, travis could still handle it.
Here, the interesting thing is just the Dockerfile so anyone can build the image for linux.
I'm looking in travis if we could keep the binary available to download and build for Mac OS too.

@vitallium
Copy link
Collaborator

For Windows we have a VM in Azure. But I really want to have a service that can handle all platforms.

@ariya
Copy link
Owner

ariya commented Dec 20, 2015

@mtparet Do you mind bringing this discussion to phantomjs-dev mailing-list. We've been looking for a proper CI system for PhantomJS and so far any off-the-shelf systems did not fulfill our requirements.

@zackw
Copy link
Contributor

zackw commented Dec 20, 2015

I'm also working on a Docker-based build but it doesn't quite work yet, see zackw/phantomjs/docker. I'm about to go out of town for Christmas and may not have time to do anything more with it till January.

@ariya
Copy link
Owner

ariya commented Dec 22, 2015

@zackw @mtparet Let's continue the Docker-based build discussion on #13822.

@ariya ariya closed this Dec 22, 2015
@ariya
Copy link
Owner

ariya commented Dec 23, 2015

@mtparet Never mind the mailing-list, let's continue the CI build system on #13828.

@ariya ariya mentioned this pull request Dec 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants