Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add company search by name and pagination to listAllCompanies #149

Merged
merged 7 commits into from
Apr 15, 2021

Conversation

derrickmehaffy
Copy link
Contributor

@derrickmehaffy derrickmehaffy commented Apr 8, 2021

  • Add a company search based on name
  • Add paging option to listAllcompanies

(First time contributing to this project so do let me know if I am missing something)

TODO:

  • Fix tests without params for listAllCompanies
  • Create test for searchCompany

Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
lib/client.js Outdated Show resolved Hide resolved
lib/client.js Outdated Show resolved Hide resolved
@derrickmehaffy
Copy link
Contributor Author

@arjunkomath question for you, do I need to manually update the docs or is that handled automatically. I assume I need to update the README for the new options yeah?

Copy link
Owner

@arjunkomath arjunkomath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@derrickmehaffy
Copy link
Contributor Author

@arjunkomath was there anything missing needed to merge and release?

@arjunkomath arjunkomath merged commit bb81b1c into arjunkomath:master Apr 15, 2021
@arjunkomath
Copy link
Owner

@arjunkomath was there anything missing needed to merge and release?

Sorry I didn't get time to release it, all done now
https://github.com/arjunkomath/node-freshdesk-api/releases/tag/v2.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants