Implemented Solutions #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
+ Coverage 72.97% 76.47% +3.49%
==========================================
Files 2 2
Lines 148 170 +22
==========================================
+ Hits 108 130 +22
Misses 40 40
Continue to review full report at Codecov.
|
|
Thanks @wvdneut I'll review and merge this week. |
|
Very cool @wvdneut. This totally fell off my radar, so glad it was still of some use! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @arjunkomath,
I saw there was a partial implementation of Solutions made by @joelcox. I used this as a starting point and also made the changes suggested in the previous discussion and PR. I hope I managed to implement these correctly now.