Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actually test PCA optimization! #24

Merged
merged 1 commit into from
Feb 10, 2024
Merged

actually test PCA optimization! #24

merged 1 commit into from
Feb 10, 2024

Conversation

arjunsavel
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d0c295c) 78.69% compared to head (4b80047) 78.03%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/cortecs/opt/optimize_pca.py 88.89% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   78.69%   78.03%   -0.67%     
==========================================
  Files          17       17              
  Lines         873      892      +19     
==========================================
+ Hits          687      696       +9     
- Misses        186      196      +10     
Flag Coverage Δ
unittests 78.03% <93.10%> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arjunsavel arjunsavel merged commit 49445dd into main Feb 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants