Fix duplicate tags when overriding tag (influxdata#4056)

arkady-emelyanov · May 18, 2018 · c3d8c34 · c3d8c34
1 parent 7c34b4c
commit c3d8c34
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/metric/metric.go b/metric/metric.go
@@ -123,6 +123,7 @@ func (m *metric) AddTag(key, value string) {
 
 		if key == tag.Key {
 			tag.Value = value
+			return
 		}
 
 		m.tags = append(m.tags, nil)

diff --git a/metric/metric_test.go b/metric/metric_test.go
@@ -63,6 +63,7 @@ func TestAddTagOverwrites(t *testing.T) {
 	value, ok := m.GetTag("host")
 	require.True(t, ok)
 	require.Equal(t, "example.org", value)
+	require.Equal(t, 1, len(m.TagList()))
 }
 
 func TestRemoveTagNoEffectOnMissingTags(t *testing.T) {