Merge pull request #18 from arkahna/fix/infinite-re-renders

Fixing infinite re-renders, the subscription triggers a set state, wh…
arkahna · Jul 24, 2023 · 6e3f800 · 6e3f800
2 parents 89e2bc2 + 9d45762
commit 6e3f800
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/tricky-meals-pay.md b/.changeset/tricky-meals-pay.md
@@ -0,0 +1,5 @@
+---
+'@featureboard/react-sdk': patch
+---
+
+Check to see if value has changed before setting state
diff --git a/libs/react-sdk/src/use-feature.ts b/libs/react-sdk/src/use-feature.ts
@@ -20,7 +20,7 @@ export function useFeature<T extends keyof Features>(
         return fbContext.client.subscribeToFeatureValue(
             featureKey,
             defaultValue,
-            (value) => setValue(value),
+            (newValue) => newValue !== value && setValue(newValue),
         )
     })