This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
Work on improving the create service principal generator #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: aa5f406 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JakeGinnivan
commented
Dec 5, 2022
| @@ -101,8 +101,30 @@ pnpm nx g \ | |||
| @arkahna/nx-terraform:add-project-environment \ | |||
| <projectname> \ | |||
| --environment <environmentname> | |||
| ``` | |||
|
|
|||
| ### create-environment-sp | |||
There was a problem hiding this comment.
I added some doco, it's now doing a fair bit
JakeGinnivan
commented
Dec 5, 2022
|
|
||
| ## Concepts | ||
|
|
||
|  |
There was a problem hiding this comment.
I think a visual around how it ends up causing the projects to be structured will be handy
JakeGinnivan
commented
Dec 5, 2022
| '--display-name', | ||
| servicePrincipalName, | ||
| ]) | ||
| const appObjectId: string = JSON.parse(stdoutAppList)[0].id |
There was a problem hiding this comment.
It now gathers and outputs the AD Object ID as well as the app id and the app Object ID.
Different commands need one of these ids.
It then stores all 3 in the dev markdown.
Merged
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.