Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spinner not updating #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

BobbyGerace
Copy link

#15

I ran into this same issue... looks like the timer wasn't implemented correctly and so the spinner was relying on status updates.

Wrapping the function in a vim.schedule_wrap appears to fix the problem

@icholy
Copy link

icholy commented Apr 21, 2022

This fix is working for me. But reading the code, I'm surprised that the timer is never stopped.

@BobbyGerace
Copy link
Author

That is a good point... I'd expect the timer to stop when the lsp has finished loading. I'd be happy to include that in this PR too if @arkav is okay with it.

@icholy
Copy link

icholy commented Apr 21, 2022

Should probably be a separate PR.

@effinsky
Copy link

is this solved on master? I only want to use the spinner but it's super janky.

mutate_section_c {
  "lsp_progress",
  display_components = { "spinner" },
  separators = {
    component = " ",
    progress = " | ",
    spinner = { pre = " ", post = " " },
  },
  timer = { spinner = 500 },
  spinner_symbols = {
    "[    ]",
    "[=   ]",
    "[==  ]",
    "[=== ]",
    "[====]",
    "[ ===]",
    "[  ==]",
    "[   =]",
    "[    ]",
    "[   =]",
    "[  ==]",
    "[ ===]",
    "[====]",
    "[=== ]",
    "[==  ]",
    "[=   ]",
  },
}

@WhoIsSethDaniel
Copy link

@effinsky please try https://github.com/WhoIsSethDaniel/lualine-lsp-progress.nvim instead of this. This repo is no longer maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants