Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit revision #1

Merged
merged 1 commit into from
Feb 21, 2024
Merged

audit revision #1

merged 1 commit into from
Feb 21, 2024

Conversation

taitruong
Copy link
Member

No description provided.

@taitruong taitruong changed the title fix spelling audit revision Jan 23, 2024
@taitruong
Copy link
Member Author

"3. It is not best practice to overwrite info.sender"

Fixed, by passing nft contract instead of info. On a bigger scope, we have realized there's a small difference between ReceiveNFT and ReceiveProxyNft.
ics721 has been refactored and now uses only ReceiveNft for handling both cases - only difference now is that binary msg in ReceiveNFT is either of type IbcOutgoingProxyMsg or IbcOutgoingMsg.
This way it reduces complexity and has same logic for both cases.

Refactoring here: public-awesome/cw-ics721@c46edd4

Remove info.sender here: arkprotocol/ark-cw-ics721@461df16

@taitruong
Copy link
Member Author

"4. Remove key-value duplication in maps"
Fixed, as suggested in report in commits:

@taitruong taitruong merged commit 9c2502d into main Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@taitruong