Remove Group import

arkworks-rs · May 10, 2023 · 2266869 · 2266869
1 parent 0263f26
commit 2266869
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 8 deletions.
diff --git a/ec/src/scalar_mul/glv.rs b/ec/src/scalar_mul/glv.rs
@@ -1,4 +1,4 @@
-use crate::Group;
+use crate::AdditiveGroup;
 use crate::{
     short_weierstrass::{Affine, Projective, SWCurveConfig},
     CurveGroup,

diff --git a/ec/src/scalar_mul/mod.rs b/ec/src/scalar_mul/mod.rs
@@ -5,11 +5,8 @@ pub mod fixed_base;
 pub mod variable_base;
 
 use crate::PrimeGroup;
-use crate::{
-    short_weierstrass::{Affine, Projective, SWCurveConfig},
-    Group,
-};
-use ark_ff::Zero;
+use crate::short_weierstrass::{Affine, Projective, SWCurveConfig};
+use ark_ff::{AdditiveGroup, Zero};
 use ark_std::{
     ops::{Add, AddAssign, Mul, Neg, Sub, SubAssign},
     vec::Vec,

diff --git a/ff/README.md b/ff/README.md
@@ -70,7 +70,7 @@ let d = a - b;
 // ... double elements ...
 assert_eq!(c + d, a.double());
 // ... negate them ...
-assert_eq!(d, F::zero() - d);
+assert_ne!(d, -d);
 
 // ... and multiply them by scalars:
 let e = d * c;

diff --git a/test-templates/src/glv.rs b/test-templates/src/glv.rs
@@ -3,7 +3,7 @@ use std::ops::Mul;
 use ark_ec::{
     scalar_mul::{glv::GLVConfig, sw_double_and_add_affine, sw_double_and_add_projective},
     short_weierstrass::{Affine, Projective},
-    AffineRepr, CurveGroup, Group,
+    AffineRepr, CurveGroup, PrimeGroup,
 };
 use ark_ff::PrimeField;
 use ark_std::UniformRand;