-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve primitive biginteger operations #204
Conversation
09a27ed
to
3fc483c
Compare
@@ -119,8 +164,14 @@ macro_rules! bigint_impl { | |||
} | |||
|
|||
#[inline] | |||
#[ark_ff_asm::unroll_for_loops] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to benchmark this change on larger fields as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are probably right. This will currently involve changing a lot of Cargo.toml files to point to my local repo. I'll try to fix some of the issues I find in this process.
Things I am not sure about:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these changes LGTM. Holding off on approving until we have confirmed performance improvements of always unrolling on varying field sizes.
@ValarDragon this PR is subsumed by #205, minus the |
I thought this PR also removed more |
Recounted, it is indeed not fully subsumed. The assert for |
closed in favour of #205 |
Description
Details and benchmarks discussed here: #198
Related PR: #199, now #205
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the Github PR explorer