Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation in ec and ff #246

Merged
merged 6 commits into from
Apr 21, 2021
Merged

Improve documentation in ec and ff #246

merged 6 commits into from
Apr 21, 2021

Conversation

Pratyush
Copy link
Member

Description

Improves documentation and closes #226.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current form of this PR LGTM! Not sure what else is planned to go under this PR

@ValarDragon
Copy link
Member

Can we go ahead and merge this for now, and do some follow-on PR's later to continue improving the docs?

@ValarDragon ValarDragon marked this pull request as ready for review April 21, 2021 17:43
@ValarDragon ValarDragon merged commit bfa7043 into master Apr 21, 2021
@ValarDragon ValarDragon deleted the improve-ec-ff-docs branch April 21, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Ord, PartialOrd bounds from Field and ProjectiveCurve/AffineCurve traits
3 participants