Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scalar multiplication impl for DensePolynomial #258

Merged
merged 5 commits into from
Apr 3, 2021

Conversation

ryanleh
Copy link
Contributor

@ryanleh ryanleh commented Apr 3, 2021

Description

Removes the need for performing FFTs when multiplying polynomials by a field element.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@ryanleh ryanleh requested a review from Pratyush April 3, 2021 05:41
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jon-chuang
Copy link
Contributor

Can this be made into a more general version where the polynomial is of small degree (i.e. of smaller degree than the log of the degree of the bigger poly)

@Pratyush
Copy link
Member

Pratyush commented Apr 3, 2021 via email

@Pratyush Pratyush merged commit 0bd355b into arkworks-rs:master Apr 3, 2021
@ryanleh ryanleh mentioned this pull request Apr 4, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants