-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 448-bit integers and fields #261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Changing this to draft while I check that it actually works for Pluto/Eris (there seems to be some minor problem with |
These are needed for the Pluto and Eris curves (https://github.com/daira/pluto-eris). Signed-off-by: Daira Hopwood <daira@jacaranda.org>
I didn't miss anything. When testing with the Pluto/Eris implementation I just needed to patch
And then it works. So, I think this PR is fine. (I rebased it relative to the 0.2.0 release for more straightforward testing, and removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Add support for 448-bit integers and fields. These will be needed for the Pluto and Eris curves
(https://github.com/daira/pluto-eris).
The changes are trivial and amount to applying the existing macros to a length of 448 bits (7 64-bit words).
This interacts with #186, but it should be easy to resolve any conflict.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Linked to Github issue with discussion and accepted designOR have an explanation in the PR that describes this work.Pending
section inCHANGELOG.md
Files changed
in the Github PR explorer