-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ToBytes
and FromBytes
#417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI job will complain for now, until corresponding fixes are made afterwards in curves, so should be good to go 👍🏼
A reason why we previously keep them is that they are, at least expected, to match the constraint counterparts, What do you think? |
I think for usage in constraint world, we need a |
These traits no longer exist upstream. Instead we should be using the `CanonicalDeserialize` or `CanonicalSerialize` traits: arkworks-rs/algebra#417
These traits no longer exist upstream. Instead we should be using the `CanonicalDeserialize` or `CanonicalSerialize` traits: arkworks-rs/algebra#417
Description
As per title. These traits are insecure, often incorrect, and have been superseded by
CanonicalSerialize
andCanonicalDeserialize
. Closes #390Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer