Fix #479: Use workspace inheritance for dependencies #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aphoh
requested review from
Pratyush,
mmagician and
weikengchen
and removed request for
a team
weikengchen
reviewed
Dec 23, 2022
ec/Cargo.toml
Outdated
| @@ -14,25 +14,25 @@ edition = "2021" | |||
| rust-version = "1.57" | |||
There was a problem hiding this comment.
@Pratyush just a quick check, this means that our minimal support version is 1.64 right?
There was a problem hiding this comment.
Suggested change
| rust-version = "1.57" | |
| rust-version = "1.64" |
If we clone algebra inside curves, it will look at the curves Cargo.toml for workspace dependencies. Cloning it outside fixes this.
|
Merged master and pushed a fix that should work for the failing CI item. |
|
added that we may put it in "the version" immediately after 0.4.0 due to the need to increase MSVP. |
|
This failing CI item works for me when I run it locally with |
Pratyush
requested changes
Jan 10, 2023
|
We should finally incorporate this (and bump rust version) in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #479
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.md(does this require a mention in the changelog? Not super relevant to consumers of the library)Files changedin the GitHub PR explorer