-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up hash-to-field #678
Conversation
@@ -2,98 +2,116 @@ | |||
// With some optimisations | |||
|
|||
use ark_std::vec::Vec; | |||
use digest::{DynDigest, ExtendableOutput, Update}; | |||
|
|||
use digest::{FixedOutputReset, ExtendableOutput, Update}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So IIUC Digest
is a supertrait of FixedOutputReset
and we just don't need all of supertrait functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You cannot use Digest + ExtendableOutput
which makes Digest
useless in practice.
db9947a
to
6ec3708
Compare
Just fyi, I've also pulled out a branch which contains the larger subsequent changes to hash-to-field: https://github.com/burdges/algebra/commits/xof_h2f It looks easier if it's merged with some curve changes though. |
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
s/count/N/
b4564dc
to
34a7211
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once tests are fixed!
104e60c
to
536515a
Compare
It's been a while so I've forgotten how to trigger the expander/tests.rs to be built locally. lol I figured this out one before. I'd though it was cargo test form the repo root, but that doesn't seem to do it right now. I should look at the CI maybe. |
536515a
to
204b3b8
Compare
204b3b8
to
93bd53c
Compare
CI is happy now |
There's a little conflict; you'll have to move the |
4025748
to
c15599d
Compare
Alright fixed I think, thanks :) |
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu> Co-authored-by: ¨Jeff <¨burdges@gnunet.org¨>
This reverts commit 9469e1b.
Description
Fixes poor usage of Digest, unnecessary allocations, poor style, etc. Nothing complex here.
Please merge #677 first.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer