-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation on WASM #794
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrxi
requested review from
z-tech,
mmagician and
weikengchen
and removed request for
a team
February 27, 2024 14:27
Pratyush
reviewed
Feb 27, 2024
Pratyush
reviewed
Feb 27, 2024
Disable loop unrolling for `Fp::into_bigint` that led to WASM miscompilations with too many local variables: ``` Error: failed to deserialize wasm module Caused by: 0: failed to parse code section 1: locals exceed maximum (at offset 16977) ``` Issue diagnosed by @paberr and @ii-cruz. Fixes arkworks-rs#615.
hrxi
force-pushed
the
pr_fix_wasm_compilation
branch
from
February 27, 2024 16:24
9b0d78e
to
3e0ce6d
Compare
Squashed everything. |
Automerge won't work: CI fails on nightly unrelated to this PR:
|
Pratyush
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable loop unrolling for
Fp::into_bigint
that led to WASM miscompilations with too many local variables:Issue diagnosed by @paberr and @ii-cruz.
Fixes #615.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Wrote unit tests-- not applicable, this is about compilation failureUpdated relevant documentation in the code-- not applicablePending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer