New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ToBytes and FromBytes for u128 #94

Merged

weikengchen merged 2 commits into master from to_from_bytes_for_u128

Nov 24, 2020

Member

weikengchen commented Nov 24, 2020 •

edited

Loading

Description

This PR adds ToBytes and FromBytes for u128

Targeted PR against the correct branch (main)
Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
Wrote unit tests
Updated relevant documentation in the code
Added a relevant changelog entry to the Pending section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

weikengchen added 2 commits

November 23, 2020 16:13


          add the to and from bytes for u128

378ac4f


          update the CHANGELOG

6f53f7c

Pratyush approved these changes

View reviewed changes

weikengchen merged commit b58cc70 into master

weikengchen deleted the to_from_bytes_for_u128 branch

November 24, 2020 00:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet