feat: massive operator refactor #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dejanzele
commented
Sep 28, 2023
dejanzele
commented
- update operator dependencies and align with latest kubebuilder format
- bugfixes
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
==========================================
+ Coverage 84.17% 84.19% +0.01%
==========================================
Files 15 15
Lines 3437 3441 +4
==========================================
+ Hits 2893 2897 +4
Misses 381 381
Partials 163 163
☔ View full report in Codecov by Sentry. |
richscott
approved these changes
Sep 29, 2023
| goos: | ||
| - linux | ||
| goarch: | ||
| - amd64 | ||
| - arm64 |
| @@ -154,7 +125,7 @@ go-release-build: goreleaser | |||
| # (i.e. docker build --platform linux/arm64 ). However, you must enable docker buildKit for it. | |||
| # More info: https://docs.docker.com/develop/develop-images/build_enhancements/ | |||
| .PHONY: docker-build | |||
| docker-build: test ## Build docker image with the manager. | |||
There was a problem hiding this comment.
💯 This always used to annoy me.
| @@ -18,9 +18,11 @@ package v1alpha1 | |||
|
|
|||
| import ( | |||
| "k8s.io/apimachinery/pkg/runtime" | |||
| "k8s.io/utils/ptr" | |||
There was a problem hiding this comment.
This package is new to me - it looks very useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.