Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make ClusterIssuer optional to allow certmanager defaults #299

Merged

Conversation

jpoler
Copy link
Contributor

@jpoler jpoler commented Apr 16, 2024

Certmanager is capable of setting it's own default issuer. Armada operator requires that .Spec.ClusterIssuer is supplied and hardcodes cluster issuer annotations. This precludes the ability to rely on certmanager defaults.

This PR makes ClusterIssuer optional, and only attaches cluster issuer annotations when ClusterIssuer is supplied.

@dejanzele
Copy link
Member

Thanks for the PR @jpoler, I'll test it out now

@dejanzele dejanzele merged commit f626b80 into armadaproject:main May 9, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants