-
Notifications
You must be signed in to change notification settings - Fork 134
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add Pod Issue handling for jobs created using Executor API (#2065)
* [WIP] Initial implementation of executor using executor API * Handle minor api change - using pointers for NodeInfo * Tidy ingress details * gofumpt * Fix unit tests * goimports * Limit event sequence size * Fix for bad merge * Fix ingress and service count * Set preempted run id * Update internal/executor/reporter/event_sender.go * Fix merge issue * Merge branch 'master' into executor_pulsar_api_initial # Conflicts: # internal/executor/reporter/fake/job_event_reporter.go # internal/executor/reporter/job_event_reporter.go # internal/executor/service/cluster_allocation.go # internal/executor/service/job_manager.go # internal/executor/service/job_manager_test.go * Add Pod Issue handling for jobs created using Executor API As part of the migration to using the Executor API, we now have 2 flows through the executor The new flow had no handling of stuck pods, which is what this PR introduces It was simpler to split this off as the handling is slightly different to existing code - Existing code is tied in with lease handling - The existing code has to make additional calls (return lease, report done) - where the new executor api is purely event based * gofumpt * Remove comments * Populate runAttempted in return lease event * Tidy up * Tidy from code review
- Loading branch information
1 parent
99c89e3
commit 13361d8
Showing
13 changed files
with
567 additions
and
99 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.