Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Lower Python Client Versions #1997

Merged
merged 5 commits into from
Jan 11, 2023
Merged

Support Lower Python Client Versions #1997

merged 5 commits into from
Jan 11, 2023

Conversation

Sharpz7
Copy link
Contributor

@Sharpz7 Sharpz7 commented Jan 10, 2023

Closes #1996

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023

Codecov Report

Base: 46.09% // Head: 46.07% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (0e15bd9) compared to base (eba0b72).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1997      +/-   ##
==========================================
- Coverage   46.09%   46.07%   -0.03%     
==========================================
  Files         205      205              
  Lines       27712    27712              
==========================================
- Hits        12773    12767       -6     
- Misses      14061    14064       +3     
- Partials      878      881       +3     
Flag Coverage Δ
airflow-operator 89.13% <ø> (ø)
armada-server 44.94% <ø> (-0.03%) ⬇️
python-client 93.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/common/pgkeyvalue/pgkeyvalue.go 75.28% <0.00%> (-3.38%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

kannon92
kannon92 previously approved these changes Jan 11, 2023
@Sharpz7 Sharpz7 enabled auto-merge (squash) January 11, 2023 16:42
@Sharpz7 Sharpz7 merged commit e5fc172 into armadaproject:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python Client - Support Lower Versions of Protobuf for ML Libraries
4 participants