Scheduling controls on queues and labels #3751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure not yet complete
Also renamed testfixture constants to be more consistent with others
…scheduling paused to constraints.
We had a bug where unfeasibleSchedulingKeys was being populated incorrectly, which led to all jobs of a particular shape being banned for that scheduling round. By fixing this bug we also broke some tests which relied on UnsuccessfulJobSchedulingContexts being populated correctly. However, this data structure was only populated if a job was marked as unsuccessful because it's scheduling key was in unfeasibleSchedulingKeys. Fixing this bug should also fix inaccuracies in metrics, as well as provide better job scheduling reporting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
control-schedulingcommand withpauseandresumesub-commandsmatch-labels,match-queues,dry-runandinverseflags on sub-commands allow better transparency and control on actions being taken.