Fixing unfeasible scheduling keys bug (#182) #3845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixing unfeasible scheduling keys bug * Renaming test parameter to be more consistent with other parameters * Renaming constraints
d80tb7
approved these changes
Jul 29, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing unfeasible scheduling keys bug
Renaming test parameter to be more consistent with other parameters
Renaming constraints
This is a fix for a bug where unfeasibleSchedulingKeys was being populated incorrectly:
gang_scheduler.go, which leads to all jobs of a particular shape being banned for the current scheduling round.internal/scheduler/gang_scheduler.go)internal/scheduler/queue_scheduler_test.go. Effectively, what the tests used to see as unsuccessful jobs are now seen as not considered. The jobs were in reality never considered and only seen as unsuccessful because of an optimisation done for jobs with scheduling keys seen inunfeasibleSchedulingKeys.internal/scheduler/gang_scheduler_test.goto ensure thatunfeasibleSchedulingKeyswas being populated for the right reason. Much of the diffs in this file are just reformatting.