Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cordon queue (#183) #3851

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Cordon queue (#183) #3851

merged 2 commits into from
Aug 1, 2024

Conversation

MustafaI
Copy link
Contributor

@MustafaI MustafaI commented Aug 1, 2024

  • Dropping queues table

  • Plumbing in cordoning mechanism

  • Adding tests

  • Generating proto with the correct version

  • Removing method name from queue_service error messages

  • Moving rate-limit comment

  • Removing swagger diffs

Summary of changes:

  • Added RPC calls to queueRepository to allow cordoning and uncordoning of queues
  • Implemented cordoning of Queues:
    • Demand for cordoned queues excludes queued items, since they can't be scheduled
    • Implemented by adding a cordoned constraint to per-queue constraints
    • Extended queue type to include cordoned flag and labels
    • Added tests to validate correctness of cordoning functionality

mustafai-gr and others added 2 commits August 1, 2024 13:57
@mustafai-gr
Cordon queue (#183)
0e53fec 
* Dropping queues table

* Plumbing in cordoning mechanism

* Adding tests

* Generating proto with the correct version

* Removing method name from queue_service error messages

* Moving rate-limit comment

* Removing swagger diffs
@MustafaI
Merge branch 'master' into sendToGitHub/cordon-queue
a606a2d
@d80tb7 d80tb7 enabled auto-merge (squash) August 1, 2024 14:42
@d80tb7 d80tb7 merged commit e41e814 into master Aug 1, 2024
28 checks passed
@d80tb7 d80tb7 deleted the sendToGitHub/cordon-queue branch August 1, 2024 14:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d80tb7 d80tb7 d80tb7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MustafaI @d80tb7 @mustafai-gr