-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EpollAsyncServerSocketChannel#bind(null) should use wildcard, not give NPE #63
Comments
Using a wildcard seems reasonable. Note that FS2 will never pass a null value here, but being compliant here is easy. |
Good to know the context. Thank you Some weenie writing test code might pass a null ;-) I discovered this by trying to use it In general Scala code I have little patience for people passing null's around. However, |
I note for future reference that the C getaddrinfo specification & practice is to treat |
Fix #63: Server bind(null) becomes JVM bind(wildcard)
The Java spec for ServerSocketChannel#bind(null) states that a null argument
should use an address of Java's choice. The JVM appears to use the wildcard
address for the underling implementation socket '0.0.0.0' or "::0" (expanded).
I believe there is a description else where which directs the use of wildcard.
I believe this is architecture and os version independent.
Code in
EpollAsyncServerSocketChannel#bind
should be relativelyeasy to fix.
The text was updated successfully, but these errors were encountered: