Factor out toAddrinfo helper

[armanbilge]

Very sorry to interrupt IPv6 work @LeeTibbert ...

This PR factors out the two uses of getaddrinfo into a single, shared method. This should reduce the amount of changes necessary for IPv6. I hope it helps you more than it distracts.

[LeeTibbert]

Thank you for the update.
I have been working on the IPv6 stuff all day.
I have caught a couple of places which were not evident.

Whilst ratting around, I noticed the opportunity to factor
out some of the getaddrinfo stuff. A little of the handling
differs between the two.

I'll take a walk, switch context, clear my mind, and come
back to review.

I've been trying to find a bit of tricky code that I know that I
wrote no more than a week ago, no luck. Arrgh!

Thank you for doing this refactor.

[LeeTibbert]

LGTM, thank you for the opportunity to review.

1. I triple checked the "rtn == 0" in one file and "rtn != 0" in the other.
   Looks like you got rid of that incongruity and the replacement
   looks correct to me.

2. An added benefit is that you removed the non-local return
   that I have been whistling past for a while. That heads
   off SN 3.2.0 quite vocal warnings.

[LeeTibbert]

LGTM -- looks correct and much easier to follow.

[armanbilge]

Thanks, I'm glad you liked it. Sincere apologies for any merge conflicts I am about to create for you :(

[LeeTibbert]

Sincere apologies for any merge conflicts I am about to create for you :(

Thank you for your concern & consideration. Life on the bleeding edge!