Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent SIGPIPE signals #67

Merged
merged 1 commit into from
Sep 18, 2022
Merged

Prevent SIGPIPE signals #67

merged 1 commit into from
Sep 18, 2022

Conversation

armanbilge
Copy link
Owner

@armanbilge armanbilge commented Sep 17, 2022

More cross-platform mess 😩 . Fixes #35.

I was unable to write a test, and based on the blog in #35 (comment) it seems writing such a test is very difficult. So I did not further waste my time on the matter.

Lee, thanks for putting me onto this issue, and I'm sorry that I didn't listen sooner!

@armanbilge armanbilge changed the title Handle SIGPIPE Prevent SIGPIPE signals Sep 17, 2022
@armanbilge
Copy link
Owner Author

@lolgab I published a snapshot of this branch. If you have a moment, would be great to confirm if this solves your problem.
https://s01.oss.sonatype.org/content/repositories/snapshots/com/armanbilge/epollcat_native0.4_2.13/0.1.0-10-f577392-SNAPSHOT/

Thanks again for reporting this with such a great reproducer!

@lolgab
Copy link
Collaborator

lolgab commented Sep 17, 2022

Tested in my machine and the snapshot dependency fixes the problem. Thank you!

@LeeTibbert
Copy link
Collaborator

I am late to the party. Things move quickly, good to see.

I read the code late last night and could see no
obvious concerns. Good to see @lolgab 's confirmation from the field.

Hi, Lorenzo!

@armanbilge armanbilge merged commit 2274dac into main Sep 18, 2022
@armanbilge armanbilge deleted the pr/i35 branch September 18, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent SIGPIPE signals
3 participants