Fix test output interleaving #69
Conversation
| @@ -46,6 +46,7 @@ lazy val tests = crossProject(JVMPlatform, NativePlatform) | |||
| .enablePlugins(NoPublishPlugin) | |||
| .nativeConfigure(_.dependsOn(core)) | |||
| .settings( | |||
| Test / testOptions += Tests.Argument("+l"), | |||
There was a problem hiding this comment.
Any idea what the +ell means? I spent some time on the Web looking for it
in both the sbt and munit docs. Seem like kind of a "If this person gets hit by a bus..."
maintenance situation.
Is it something inherited from PR which provided the template for this PR?
That is understandable & far better than the quirks before.
There was a problem hiding this comment.
Yes I had to do quite a bit of digging as well. It comes from here:
https://github.com/scalameta/munit/blob/92710a507339d20368d251feadf66e4f9f4e1840/junit-interface/src/main/java/munit/internal/junitinterface/JUnitRunner.java#L64-L102
I believe it is equivalent to setting --logger=sbt. So I will switch to use that and add a comment linking to the above.
There was a problem hiding this comment.
Yes!
It is a delicate balancing act between up-front actually-spent costs spent now versus
envisioned downstream maintenance costs maybe/maybe_not spent by somebody else.
In an open-source project which hopes to attract additional developers, having a
good model/template has value.
In my mind you strike a good balance.
There was a problem hiding this comment.
Amazingly, --logger=sbt does not work ... no idea at this point 😂 so I just added plenty of comments, and kept this current solution.
There was a problem hiding this comment.
note that
--logger=sbtdid not work for some reason
Gotta love quirks! Without them we would have nothing to
do but sit on the beach and watch the waves roll in.
You just saved someone, like me, from stepping into a time suck.
I think this fixes the problem noted here:
epollcat/tests/shared/src/test/scala/epollcat/Tcp6Suite.scala
Lines 69 to 76 in 0128e88
This is annoying but with only a couple test suites I had been ignoring the issue. Fortunately your comment reminded me of scala-js/scala-js-macrotask-executor@2179a6c.
I tested this locally and indeed it seems to have improved the situation.