wifi: rtl8852bs: add driver for family instead of board

[amazingfate]

Description

Each family should build the same kernel.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

• ./compile.sh kernel BOARD=armsom-sige5 BRANCH=vendor DEB_COMPRESS=xz KERNEL_CONFIGURE=no KERNEL_GIT=shallow

Checklist:

Please delete options that are not relevant.

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

[ColorfulRhino]

Nooooo, I specifically introduced this change to lessen the wifi driver craze so that only boards who actually have this wifi chip get the driver. This is also to prevent the people bumping a kernel to also have to tackle wifi patching issues in addition of the normal troubles of kernel bumping. The driver patching should be handled by the maintainers who actually own the devices that use those and care about them, in my opinion. For others it's just a burden :(

Do you have a different solution to this problem?

[amazingfate]

Nooooo, I specifically introduced this change to lessen the wifi driver craze so that only boards who actually have this wifi chip get the driver. This is also to prevent the people bumping a kernel to also have to tackle wifi patching issues in addition of the normal troubles of kernel bumping. The driver patching should be handled by the maintainers who actually own the devices that use those and care about them, in my opinion. For others it's just a burden :(

Do you have a different solution to this problem?

One kernel family and two versions of kernel deb, I don't think this is good.

We already have a lot of wifi driver patches, and they are all patched to kernel family, not board. RTL8852BS is enabled in kernel config, and the kernel config is shared by all the boards in family. If you make it limitted to several boards, when somebody does a kernel-rewrite-config, the wifi config may get disabled.

[amazingfate]

If you want per-board wifi drivers, dkms deb should be a better solution: https://github.com/armbian/build/blob/main/extensions/radxa-aic8800.sh

[ColorfulRhino]

Yes, I do understand the limitations of the current system now and why this change is needed. Doesn't make it less of a burden though 😅

If you want per-board wifi drivers, dkms deb should be a better solution

I was just thinking this as well, distributing all wifi drivers as dkms module to be able to be installed only when needed would probably be the best solution.

Since I don't want to get burnt-out, I will just hardcode EXTRAWIFI=no from now on into my local build system since I spent too much time in the past having to deal with unrelated wifi patching issues when bumping kernels. Others will have to deal with the patching, sorry.

[rpardini]

Since I don't want to get burnt-out, I will just hardcode EXTRAWIFI=no from now on into my local build system

burn-out is real. We're not striving enough to avoid that.

In this case, wifi-drivers have long been identified as a huge pain point. Every single person who fixes them on each bump is a hero and deserves all respect.

The fact that LINUXFAMILY (vs BOARDFAMILY) vs BOARD has been designed upside-down is also a pain point, but we can't simply introduce BOARD as a variable in something that is driven by LINUXFAMILY.

This subject is about the both of them. With the added sadness of having lost Larry Finger. Let's keep positive and envision the possible solutions, focused on maintainer happyness, I'd say. DKMS might be a good alternative indeed.