Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dedicated CONTRIBUTION.md and adjust README.md #220

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Add dedicated CONTRIBUTION.md and adjust README.md #220

merged 1 commit into from
Oct 31, 2024

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Oct 31, 2024 •
edited
Loading

Description

Current ones had hard-coded build framework instructions. Removing that, adjust Readme.md with git clone to run instructions.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have ensured that my changes do not introduce new warnings or errors
  • No new external dependencies are included
  • Changes have been tested and verified
  • I have included necessary metadata in the code, including associative arrays

@igorpecovnik
Add dedicated CONTRIBUTION.md whih had hardcoded build framework inst…
4266d71 
…ructions. Remove that, adjust Readme with instrucrions how to clone and run.
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines Documentation Documentation changes or additions and removed size/medium PR with more then 50 and less then 250 lines labels Oct 31, 2024
@igorpecovnik igorpecovnik added the 11 Milestone: Fourth quarter release label Oct 31, 2024
Tearran
Tearran approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@Tearran Tearran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition.

@Tearran Tearran merged commit 28a3ddc into main Oct 31, 2024
35 of 41 checks passed
@Tearran Tearran deleted the contrib branch October 31, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tearran Tearran Tearran approved these changes

Assignees
No one assigned
Labels
11 Milestone: Fourth quarter release Documentation Documentation changes or additions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorpecovnik @Tearran