Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module template example - Practical use webmin #240

Merged
merged 12 commits into from
Nov 9, 2024
Merged

Conversation

Tearran
Copy link
Member

@Tearran Tearran commented Nov 8, 2024

Description

A module template based on portrainer module

the --api option for automation and testing

"./bin/armbian-config" --api module_portainer install
"./bin/armbian-config" --api module_portainer uninstall

@github-actions github-actions bot added the size/medium PR with more then 50 and less then 250 lines label Nov 8, 2024
@Tearran
Copy link
Member Author

Tearran commented Nov 8, 2024

./bin/armbian-config" --api module_webmin help

shows all commands and a list of currently usable commands


Usage: module_webmin <command>
Commands: help install remove start stop enable disable status check
Available commands:
        stop    - Stop the webmin service.
        disable - Disable webmin from starting on boot.
        status  - Show the status of the webmin service.
        remove  - Remove webmin.

@Tearran
Copy link
Member Author

Tearran commented Nov 8, 2024

Module Menu

./bin/armbian-config --api see_menu module_webmin
image

@github-actions github-actions bot added size/large PR with 250 lines or more and removed size/medium PR with more then 50 and less then 250 lines labels Nov 8, 2024
@Tearran Tearran changed the title Module template Module template example - Practical use webmin Nov 8, 2024
@Tearran Tearran added Feature Request Feature suggestion Framework Framework components Ready to merge Reviewed, tested and ready for merge Needs review Seeking for review labels Nov 8, 2024
@igorpecovnik
Copy link
Member

Good to have some standards applied here!

It would be good to update instructions to use template:
https://docs.armbian.com/User-Guide_Armbian-Software/

Should tools/modules/functions/interface_menu.sh also have module_info section at start?

@Tearran
Copy link
Member Author

Tearran commented Nov 8, 2024

Should tools/modules/functions/interface_menu.sh also have a module_info section at the start?

Yes

Tearran and others added 4 commits November 8, 2024 19:34
	modified:   tools/modules/software/install_uptime-kuma.sh
	modified:   tools/modules/software/install_webmin.sh
@github-actions github-actions bot added the Documentation Documentation changes or additions label Nov 9, 2024
@igorpecovnik igorpecovnik merged commit 95722fe into main Nov 9, 2024
32 checks passed
@igorpecovnik igorpecovnik deleted the module_template branch November 9, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation changes or additions Feature Request Feature suggestion Framework Framework components Needs review Seeking for review Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants