Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting CPPFLAGS and LDFLAGS #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

swt2c
Copy link

@swt2c swt2c commented Feb 11, 2024

No description provided.

@TobiasFaller
Copy link
Contributor

What is the purpose of the CPPFLAGS variable? (Typically it is used for the C Pre-Processor)

What is the use of Cppflags?
CPPFLAGS is used to pass extra flags to the C preprocessor. These flags are also used by any programs that use the C preprocessor, including the C, C++, and Fortran compilers. You do not need to explicitly call the C preprocessor.

It seems that it contains additional flags for the C++ compiler which could be added to CXXFLAGS instead.
In case additional flags are required for the C compilation I suggest using CFLAGS instead.

@swt2c
Copy link
Author

swt2c commented Feb 18, 2024

What is the purpose of the CPPFLAGS variable? (Typically it is used for the C Pre-Processor)

What is the use of Cppflags?
CPPFLAGS is used to pass extra flags to the C preprocessor. These flags are also used by any programs that use the C preprocessor, including the C, C++, and Fortran compilers. You do not need to explicitly call the C preprocessor.

Well, as you noted the C preprocessor is used by C++ compilers also. In my particular case (Debian packaging), these flags are being set by the build environment, so I'd rather not have to change them.

@swt2c swt2c changed the title Add support for setting LDFLAGS Add support for setting CPPFLAGS and LDFLAGS Feb 18, 2024
@arminbiere
Copy link
Owner

For external input, we have the policy to have the commits signed:

See CONTRIBUTING.md.

Signed-off-by: Scott Talbert <swt@techie.net>
@swt2c
Copy link
Author

swt2c commented Mar 31, 2024

For external input, we have the policy to have the commits signed:

See CONTRIBUTING.md.

Done (and rebased).

@arminbiere
Copy link
Owner

In another context it was mentioned that those flags handed to configure should not be changed and used as is for compilation. We first need to research that before we change the way how this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants