chore(update): gen-manifests update #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(telemetry): add ability to report deploy method to "echo" via telemetry * feat(telemetry): code formatting
It looks like gate and deck were overriding `buildServiceSettings` just to avoid calling `setAddress`. But then when the JVM flags got added to that method, they both got skipped. Since `deck` doesn't use a JVM, that's no big deal, but for `gate` it's an issue. Held my nose and went for a minimally invasive change rather than a more holistic cleanup.
…ker#1549) * refactor(kubernetes): separate V1 and V2 account validators * feat(kubernetes): add warning for v1 accounts * feat(cli): only expose providerVersion for kubernetes accounts * feat(kubernetes): default new and unspecified accounts to V2
* feat(plugins): lays down plugin-manifest for Deck * chore(style): spotless apply * fix(plugins): using template for plugin entries for deck * fix(plugins): corrected filename for plugin-manifest.json Co-authored-by: Cameron Motevasselani <cmotevasselani@gmail.com>
1. Add an AbstractEditCiCommand class that could be inherited from. For now only codebuild account command extends this class. There could be more in the future. 2. Mark assume-role and account-id as not required so that the static credentials could be used directly 3. Add an API in halyard daemon to set custom fields for CI providers Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Travis CI User <travis@example.org>
Co-authored-by: Travis CI User <travis@example.org>
Co-authored-by: Travis CI User <travis@example.org>
* chore(containers): tell curl to fail if it gets an HTTP error This will prevent errors from going unnoticed as happened with the missing AWS client. * chore(containers): Upgrade the bundled tools
…1565) * feat(stats): Rename telemetry to stats, enable by default * fix(stats): Rename TelemetryWrapper to StatsWrapper
Co-authored-by: Cameron Fieber <cfieber@netflix.com>
Co-authored-by: Travis CI User <travis@example.org>
…aker#1572) * feat(k8s/deploy): Add custom health check to service-settings. Need the ability to override the default commands created and populated in the Deployments readinessprobe. In our use case mTLS has been enabled and we need a way to modify the readiness probe in each service so that you can pass in the client certificate. By adding this functionality Halyard can support a much wider array of potential configurations for health checks for cases where a simple check of /health might not be desirable. * Update var to the correct generic type * fix(k8s/deploy): Update var to the correct generic type * chore(fix/style): ran spotlessJava to fix style issues
Co-authored-by: runner <runner@fv-az51>
Co-authored-by: runner <runner@fv-az50>
Co-authored-by: runner <runner@fv-az117.internal.cloudapp.net>
Co-authored-by: runner <runner@fv-az76>
Co-authored-by: runner <runner@fv-az51>
Co-authored-by: root <root@534ce9888ac0>
Co-authored-by: root <root@167ad51ad4f2>
Co-authored-by: root <root@07aa874cb083>
Co-authored-by: root <root@fa990adebdf5>
Co-authored-by: root <root@ec7bd04f30f1>
Co-authored-by: root <root@07935c2d2f7e>
Co-authored-by: Cameron Motevasselani <cmotevasselani@gmail.com>
Co-authored-by: root <root@bfd54d97d9e4>
Co-authored-by: root <root@903b3fc96ec5>
Co-authored-by: root <root@b207540a8467>
Co-authored-by: root <root@37fd038da766>
…date # Conflicts: # Dockerfile.compile # Dockerfile.slim # Dockerfile.ubuntu # README.md # build.gradle # docs/commands.md # gradle.properties # gradle/wrapper/gradle-wrapper.jar # gradle/wrapper/gradle-wrapper.properties # gradlew # halyard-backup/halyard-backup.gradle # halyard-cli/src/main/java/com/netflix/spinnaker/halyard/cli/command/v1/ConfigCommand.java # halyard-cli/src/main/java/com/netflix/spinnaker/halyard/cli/command/v1/config/providers/kubernetes/KubernetesEditAccountCommand.java # halyard-cli/src/main/java/com/netflix/spinnaker/halyard/cli/command/v1/config/providers/tencentcloud/TencentCloudEditBakeryDefaultsCommand.java # halyard-cli/src/main/java/com/netflix/spinnaker/halyard/cli/services/v1/Daemon.java # halyard-config/src/main/java/com/netflix/spinnaker/halyard/config/config/v1/HalconfigDirectoryStructure.java # halyard-config/src/main/java/com/netflix/spinnaker/halyard/config/model/v1/ci/codebuild/AwsCodeBuild.java # halyard-config/src/main/java/com/netflix/spinnaker/halyard/config/model/v1/node/Features.java # halyard-config/src/main/java/com/netflix/spinnaker/halyard/config/model/v1/plugins/Plugin.java # halyard-config/src/main/java/com/netflix/spinnaker/halyard/config/model/v1/providers/huaweicloud/HuaweiCloudAccount.java # halyard-config/src/main/java/com/netflix/spinnaker/halyard/config/model/v1/providers/huaweicloud/HuaweiCloudBakeryDefaults.java # halyard-config/src/main/java/com/netflix/spinnaker/halyard/config/model/v1/providers/kubernetes/KubernetesAccount.java # halyard-config/src/main/java/com/netflix/spinnaker/halyard/config/model/v1/providers/tencentcloud/TencentCloudAccount.java # halyard-config/src/main/java/com/netflix/spinnaker/halyard/config/services/v1/FileService.java # halyard-config/src/main/java/com/netflix/spinnaker/halyard/config/validate/v1/StatsValidator.java # halyard-config/src/main/java/com/netflix/spinnaker/halyard/config/validate/v1/providers/kubernetes/KubernetesAccountValidator.java # halyard-config/src/test/groovy/com/netflix/spinnaker/halyard/config/model/v1/ExtensibilitySpec.groovy # halyard-deploy/src/main/java/com/netflix/spinnaker/halyard/deploy/config/v1/secrets/DecryptingObjectMapper.java # halyard-deploy/src/main/java/com/netflix/spinnaker/halyard/deploy/deployment/v1/ServiceProviderFactory.java # halyard-deploy/src/main/java/com/netflix/spinnaker/halyard/deploy/services/v1/DeployService.java # halyard-deploy/src/main/java/com/netflix/spinnaker/halyard/deploy/services/v1/GenerateService.java # halyard-deploy/src/main/java/com/netflix/spinnaker/halyard/deploy/spinnaker/v1/profile/KubernetesV2ClouddriverProfileFactory.java # halyard-deploy/src/main/java/com/netflix/spinnaker/halyard/deploy/spinnaker/v1/service/distributed/kubernetes/v2/KubernetesV2RedisService.java # halyard-deploy/src/main/resources/kubernetes/manifests/service.yml # halyard-deploy/src/test/groovy/com/netflix/spinnaker/halyard/deploy/spinnaker/v1/profile/SpringProfileFactorySpec.groovy # install/macos/InstallHalyard.sh # release/docker.sh # release/promote.sh # settings.gradle
dogonthehorizon
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we are pulling from the master branch from spinnaker/halyard.
Also, in this PR I'm deleting temporal files created during manifest creation and validation services.