fix(prometheus): handle metrics with same name but varying tags. #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functional test and integration tests attached to this PR proves that micrometer-metrics/micrometer#877 (comment) is no longer true.
I have temporarily copy and pasted the registry PrometheusMeterRegistry class:
I have modified the following the offending method to not throw and error and registry a new entry instead:
armory-observability-plugin/common/src/main/java/io/micrometer/prometheus/MutatedPrometheusMeterRegistry.java
Lines 452 to 463 in 2819e3f