This repository has been archived by the owner on Aug 27, 2023. It is now read-only.
fix: support concurrent access in system report endpoint #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: make a Github tag so the new version is available in the Go package registry. |
vladklokun
force-pushed
the
fix-system-endpoint-race
branch
from
bb2c844
to
d25cbce
Compare
Previously, concurrent access to the global system report endpoint variable resulted in a data race and triggered the race detector. This commit makes the variable safe for concurrent use. Signed-off-by: Vlad Klokun <vklokun@protonmail.ch>
vladklokun
force-pushed
the
fix-system-endpoint-race
branch
from
d25cbce
to
34a0b78
Compare
vladklokun
commented
Aug 23, 2023
Comment on lines
65
to
81
| // SetSystemReportEndpoint sets the system report endpoint to the provided | ||
| // value or a default | ||
| // | ||
| // Deprecated: the SetSysetmReportEndpoint shouldn’t be the setter for an | ||
| // unexported variable. Use the sysEndpoint.SetOrDefault() method instead. | ||
| func SetSystemReportEndpoint(endpoint string) { | ||
| systemReportEndpoint.SetOrDefault(endpoint) | ||
| } | ||
|
|
||
| // GetSystemReportEndpoint gets the system report endpoint or sets a default | ||
| // and returns it | ||
| // | ||
| // Deprecated: the GetSysetmReportEndpoint shouldn’t be the setter for an | ||
| // unexported variable. Use the sysEndpoint.GetOrDefault() method instead. | ||
| func GetSystemReportEndpoint() string { | ||
| if systemReportEndpoint == "" { | ||
| SetSystemReportEndpoint("") | ||
| } | ||
| return systemReportEndpoint | ||
| return systemReportEndpoint.GetOrDefault() | ||
| } |
There was a problem hiding this comment.
question: can we safely remove these functions?
I have only seen these functions being used inside of the armosec/logger-go package. But seeing how these are exported functions, do we expect clients of armosec/logger-go to use it?
If not, then I would like to remove the functions and also make sure that the new concurrent system report endpoint is unexported, private to the logger package.
There was a problem hiding this comment.
Do what ever you think, but there is no reason to waist here time
dwertent
approved these changes
Aug 23, 2023
Signed-off-by: Vlad Klokun <vklokun@protonmail.ch>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes?
Previously, concurrent access to the global system report endpoint variable resulted in a data race and triggered the race detector.
This commit makes the variable safe for concurrent use.