Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate codebase to Typescript #Hacktoberfest #29

Open
1 of 3 tasks
armujahid opened this issue Oct 20, 2019 · 4 comments
Open
1 of 3 tasks

Migrate codebase to Typescript #Hacktoberfest #29

armujahid opened this issue Oct 20, 2019 · 4 comments
Labels
good first issue Good for newcomers Hacktoberfest

Comments

@armujahid
Copy link
Owner

armujahid commented Oct 20, 2019 •
edited
Loading

TODO:

  • (Completed by @thebishaldeb)Typescript setup
  • add/use types
  • Review

PRs should target typescriptmigrationWIP branch
@thebishaldeb
Copy link

Would like to work on it.

@armujahid
Copy link
Owner Author

@thebishaldeb Thanks :) You can start exploring code and see what can be done. Code is very simple

@thebishaldeb
Copy link

Sure thing

@armujahid armujahid pinned this issue Oct 20, 2019
thebishaldeb added a commit to thebishaldeb/hnreact that referenced this issue Oct 20, 2019
@thebishaldeb
armujahid#29: migration from js to ts.
69cedc4
@thebishaldeb
Copy link

@thebishaldeb Thanks :) You can start exploring code and see what can be done. Code is very simple

Done!

@thebishaldeb thebishaldeb mentioned this issue Oct 20, 2019
Merged
armujahid added a commit that referenced this issue Oct 26, 2019
@armujahid
Merge pull request #30 from thebishaldeb/master
53d3bb5 
#29: migration from js to ts.
@armujahid armujahid unpinned this issue Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@armujahid @thebishaldeb