Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for text_color in tags #248

Merged

Conversation

alon-sht
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for phenomenal-crepe-0effec ready!

Name Link
🔨 Latest commit 200c4fc
🔍 Latest deploy log https://app.netlify.com/sites/phenomenal-crepe-0effec/deploys/66d5b2c874a2670008cb2ba5
😎 Deploy Preview https://deploy-preview-248--phenomenal-crepe-0effec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@arnaudmiribel
Copy link
Owner

Hey @alon-sht, thanks for the PR. I'm working on fixing the CI failing in #250

@arnaudmiribel
Copy link
Owner

@alon-sht please pull from main after #250 was merged - this should solve the deploy issue

@alon-sht
Copy link
Contributor Author

Please take a look now :)

@arnaudmiribel
Copy link
Owner

arnaudmiribel commented Aug 29, 2024

@alon-sht would you mind making sure the linting is right? We use pre-commit, hopefully you're familiar with that.

tl;dr:

pip install pre-commit
pre-commit install
pre-commit run --all

@alon-sht
Copy link
Contributor Author

It's new to me
I've ran pre-commit and fixed a bug

@arnaudmiribel
Copy link
Owner

arnaudmiribel commented Aug 29, 2024

Well done fixing the linting issues with pre-commit. Looks like there are still errors running the test: see here

By the way, wanted to call out Streamlit now has nice native way to make tags if you're interested - see colored text in docs.

image

@alon-sht
Copy link
Contributor Author

I tried adding another fix
I'm currently having trouble running pytest in my IDE for some reason.

@alon-sht
Copy link
Contributor Author

Streamlit's native way is nice, but your implementation is prettier and more versatile in terms of color options :)

@alon-sht
Copy link
Contributor Author

alon-sht commented Sep 3, 2024

Latest commit passed all tests

Copy link
Owner

@arnaudmiribel arnaudmiribel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Let's merge this 👏 @alon-sht

@arnaudmiribel arnaudmiribel merged commit 58583c4 into arnaudmiribel:main Sep 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants