Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen python version restrictions, and add matrix of tests for diffe… #49

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

blackary
Copy link
Collaborator

…rent python versions

Copy link
Owner

@arnaudmiribel arnaudmiribel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised we're not using some type hints that could throw exceptions... but let's see!

Copy link
Collaborator

@tylerjrichards tylerjrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found out why Streamlit 3.9.7 doesn't work for future reference streamlit/streamlit#5140

@tylerjrichards
Copy link
Collaborator

found out why Streamlit 3.9.7 doesn't work for future reference streamlit/streamlit#5140

you two probably knew this already!

@blackary
Copy link
Collaborator Author

@arnaudmiribel 3.7 does have some typing issues, but not 3.8+

 > mypy --python-version 3.7
src/streamlit_extras/badges/__init__.py:1: error: Module "typing" has no attribute "Literal"; maybe "_Literal"?
src/streamlit_extras/badges/__init__.py:1: error: Module "typing" has no attribute "get_args"
src/streamlit_extras/badges/__init__.py:9: error: Variable "streamlit_extras.badges._SUPPORTED_TYPES" is not valid as a type
src/streamlit_extras/badges/__init__.py:9: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
src/streamlit_extras/function_explorer/__init__.py:2: error: Module "typing" has no attribute "get_args"
src/streamlit_extras/colored_header/__init__.py:3: error: Module "typing" has no attribute "Literal"; maybe "_Literal"?
src/streamlit_extras/colored_header/__init__.py:161: error: Variable "streamlit_extras.colored_header._SUPPORTED_COLORS" is not valid as a type
src/streamlit_extras/colored_header/__init__.py:161: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants